zhangmo8 commented on code in PR #300:
URL: https://github.com/apache/paimon-webui/pull/300#discussion_r1628675516
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
I just think it is unreasonable to choose to write your own style instead of
using the relevant props provided by the component.
##########
paimon-web-ui/src/views/metadata/components/options/index.tsx:
##########
@@ -41,11 +41,12 @@ export default defineComponent({
key: 'value',
},
{
- title: 'Operation',
+ title: () => <div style={{ paddingRight: '40px' }}>Operation</div>,
key: 'operation',
+ align: 'right',
Review Comment:
If you add this padding, the distance from key to the left is not the same
as the distance from operation to the right. I think both are fine. In
addition, I don't think any users will pay attention to whether the right side
is too close, if any, pr welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
