devillove084 commented on code in PR #51:
URL: https://github.com/apache/paimon-rust/pull/51#discussion_r1719760639
##########
crates/paimon/src/error.rs:
##########
@@ -42,4 +42,21 @@ pub enum Error {
message: String,
source: opendal::Error,
},
+ #[snafu(
+ visibility(pub(crate)),
+ display("Paimon hitting unsupported io error {}", message)
+ )]
+ IoUnsupported { message: String },
+ #[snafu(visibility(pub(crate)), display("Failed to parse URL: {:?}",
source))]
+ UrlParse { source: url::ParseError },
Review Comment:
I think your suggestion is better. This error should not be exposed to
users. Users do not need to be aware of the error reported by a dependent
library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
