JingsongLi commented on code in PR #4009:
URL: https://github.com/apache/paimon/pull/4009#discussion_r1724272651
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkSink.java:
##########
@@ -222,8 +225,11 @@ public DataStream<Committable> doWrite(
commitUser))
.setParallelism(parallelism == null ?
input.getParallelism() : parallelism);
- if (!isStreaming &&
table.coreOptions().writeManifestCache().getBytes() > 0) {
- assertBatchAdaptiveParallelism(env, written.getParallelism());
+ boolean writeMCacheEnabled =
table.coreOptions().writeManifestCache().getBytes() > 0;
+ boolean hashDynamicMode = table.bucketMode() ==
BucketMode.HASH_DYNAMIC;
Review Comment:
cross_partition does rely on reading index, pk index will shuffle with data
records.
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkSink.java:
##########
@@ -222,8 +225,11 @@ public DataStream<Committable> doWrite(
commitUser))
.setParallelism(parallelism == null ?
input.getParallelism() : parallelism);
- if (!isStreaming &&
table.coreOptions().writeManifestCache().getBytes() > 0) {
- assertBatchAdaptiveParallelism(env, written.getParallelism());
+ boolean writeMCacheEnabled =
table.coreOptions().writeManifestCache().getBytes() > 0;
+ boolean hashDynamicMode = table.bucketMode() ==
BucketMode.HASH_DYNAMIC;
Review Comment:
cross_partition does not rely on reading index, pk index will shuffle with
data records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
