JingsongLi commented on code in PR #4042:
URL: https://github.com/apache/paimon/pull/4042#discussion_r1728416911
##########
paimon-arrow/src/main/java/org/apache/paimon/arrow/vector/ArrowFormatWriter.java:
##########
@@ -92,10 +92,14 @@ public boolean empty() {
return rowId == 0;
}
- @Override
- public void close() {
+ // if c++ code release this, we don't need to release again (release twice
may cause a problem)
+ public void release() {
array.release();
Review Comment:
move array and schema out of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
