askwang commented on code in PR #4059:
URL: https://github.com/apache/paimon/pull/4059#discussion_r1758476410
##########
paimon-spark/paimon-spark-common/src/main/java/org/apache/paimon/spark/procedure/ExpireSnapshotsProcedure.java:
##########
@@ -42,8 +45,9 @@ public class ExpireSnapshotsProcedure extends BaseProcedure {
ProcedureParameter.required("table", StringType),
ProcedureParameter.optional("retain_max", IntegerType),
ProcedureParameter.optional("retain_min", IntegerType),
- ProcedureParameter.optional("older_than", TimestampType),
- ProcedureParameter.optional("max_deletes", IntegerType)
+ ProcedureParameter.optional("older_than", StringType),
+ ProcedureParameter.optional("max_deletes", IntegerType),
+ ProcedureParameter.optional("time_retained", StringType)
Review Comment:
> Because there is currently compatibility issue. I recommend using a script
to address the issue of periodic calls when invoking from the outer layer.
When using a script to calls periodically, we need to adjust older_than
parameter each time. I think it is necessary to keep time_retained, what do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
