wwj6591812 commented on code in PR #4215:
URL: https://github.com/apache/paimon/pull/4215#discussion_r1769836939
##########
paimon-core/src/main/java/org/apache/paimon/Snapshot.java:
##########
@@ -357,6 +362,16 @@ public static Snapshot fromJson(String json) {
public static Snapshot fromPath(FileIO fileIO, Path path) {
try {
return Snapshot.fromJson(fileIO.readFileUtf8(path));
+ } catch (FileNotFoundException e) {
+ String errorMessage =
+ String.format(
+ "Snapshot file %s does not exist. "
+ + "It might have been expired by other
jobs operating on this table. "
Review Comment:
"by other jobs operating on this table." -> "by other write jobs on this
table." ?
##########
paimon-core/src/main/java/org/apache/paimon/Snapshot.java:
##########
@@ -357,6 +362,16 @@ public static Snapshot fromJson(String json) {
public static Snapshot fromPath(FileIO fileIO, Path path) {
try {
return Snapshot.fromJson(fileIO.readFileUtf8(path));
Review Comment:
Here my throw UncheckedIOException, could you add same logic to handle the
UncheckedIOException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
