wwj6591812 commented on code in PR #4377: URL: https://github.com/apache/paimon/pull/4377#discussion_r1816457656
########## docs/content/primary-key-table/compaction.md: ########## @@ -57,8 +57,8 @@ expect a mode to have maximum writing throughput, the compaction can be done slo You can use the following strategies for your table: ```shell -num-sorted-run.stop-trigger = 2147483647 -sort-spill-threshold = 10 +num-sorted-run.stop-trigger = 10 Review Comment: If apply this config, the commit will be block by compaction when the number of sorted-run is 10. Then writing throughput will decline. ########## docs/content/primary-key-table/compaction.md: ########## @@ -57,8 +57,8 @@ expect a mode to have maximum writing throughput, the compaction can be done slo You can use the following strategies for your table: ```shell -num-sorted-run.stop-trigger = 2147483647 -sort-spill-threshold = 10 +num-sorted-run.stop-trigger = 10 +sort-spill-threshold = 2147483647 Review Comment: I think: If apply this config, no sorted-run will be spill when compaction or mergeOnRead, maybe cause OOM. May I ask why you made this modification？ ########## docs/content/primary-key-table/compaction.md: ########## @@ -57,8 +57,8 @@ expect a mode to have maximum writing throughput, the compaction can be done slo You can use the following strategies for your table: ```shell -num-sorted-run.stop-trigger = 2147483647 -sort-spill-threshold = 10 +num-sorted-run.stop-trigger = 10 Review Comment: I think: If apply this config, the commit will be block by compaction when the number of sorted-run is 10. Then writing throughput will decline. May I ask why you made this modification？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
