wwj6591812 commented on code in PR #4666:
URL: https://github.com/apache/paimon/pull/4666#discussion_r1881204893
##########
paimon-common/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -2356,6 +2363,10 @@ public boolean statsDenseStore() {
return options.get(METADATA_STATS_DENSE_STORE);
}
+ public boolean thinMode() {
Review Comment:
dataFileThinMode
##########
paimon-core/src/main/java/org/apache/paimon/io/KeyValueThinDataFileWriterImpl.java:
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.io;
+
+import org.apache.paimon.CoreOptions;
+import org.apache.paimon.KeyValue;
+import org.apache.paimon.data.InternalRow;
+import org.apache.paimon.fileindex.FileIndexOptions;
+import org.apache.paimon.format.FormatWriterFactory;
+import org.apache.paimon.format.SimpleColStats;
+import org.apache.paimon.format.SimpleStatsExtractor;
+import org.apache.paimon.fs.FileIO;
+import org.apache.paimon.fs.Path;
+import org.apache.paimon.manifest.FileSource;
+import org.apache.paimon.table.SpecialFields;
+import org.apache.paimon.types.RowType;
+import org.apache.paimon.utils.Pair;
+
+import javax.annotation.Nullable;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.function.Function;
+
+/**
+ * Implementation of KeyValueDataFileWriter for thin data files. Thin data
files only contain
+ * _SEQUENCE_NUMBER_, _ROW_KIND_ and value fields.
+ */
+public class KeyValueThinDataFileWriterImpl extends KeyValueDataFileWriter {
+
+ private final int[] keyStatMapping;
+
+ /**
+ * Constructs a KeyValueThinDataFileWriterImpl.
+ *
+ * @param fileIO The file IO interface.
+ * @param factory The format writer factory.
+ * @param path The path to the file.
+ * @param converter The function to convert KeyValue to InternalRow.
+ * @param keyType The row type of the key.
+ * @param valueType The row type of the value.
+ * @param simpleStatsExtractor The simple stats extractor, can be null.
+ * @param schemaId The schema ID.
+ * @param level The level.
+ * @param compression The compression type.
+ * @param options The core options.
+ * @param fileSource The file source.
+ * @param fileIndexOptions The file index options.
+ */
+ public KeyValueThinDataFileWriterImpl(
+ FileIO fileIO,
+ FormatWriterFactory factory,
+ Path path,
+ Function<KeyValue, InternalRow> converter,
+ RowType keyType,
+ RowType valueType,
+ @Nullable SimpleStatsExtractor simpleStatsExtractor,
+ long schemaId,
+ int level,
+ String compression,
+ CoreOptions options,
+ FileSource fileSource,
+ FileIndexOptions fileIndexOptions) {
+ super(
+ fileIO,
+ factory,
+ path,
+ converter,
+ keyType,
+ valueType,
+ KeyValue.schema(RowType.of(), valueType),
+ simpleStatsExtractor,
+ schemaId,
+ level,
+ compression,
+ options,
+ fileSource,
+ fileIndexOptions);
+ Map<Integer, Integer> idToIndex = new HashMap<>();
Review Comment:
init map with initialCapacity
##########
paimon-core/src/main/java/org/apache/paimon/KeyValueThinSerializer.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon;
+
+import org.apache.paimon.data.GenericRow;
+import org.apache.paimon.data.InternalRow;
+import org.apache.paimon.data.JoinedRow;
+import org.apache.paimon.types.RowKind;
+import org.apache.paimon.types.RowType;
+import org.apache.paimon.utils.ObjectSerializer;
+
+/** Serialize KeyValue to InternalRow with ignorance of key. Only used to
write KeyValue to disk. */
+public class KeyValueThinSerializer extends ObjectSerializer<KeyValue> {
+
+ private static final long serialVersionUID = 1L;
+
+ private final GenericRow reusedMeta;
+ private final JoinedRow reusedKeyWithMeta;
+
+ public KeyValueThinSerializer(RowType keyType, RowType valueType) {
+ super(KeyValue.schema(keyType, valueType));
+
+ this.reusedMeta = new GenericRow(2);
+ this.reusedKeyWithMeta = new JoinedRow();
+ }
+
+ public InternalRow toRow(KeyValue record) {
+ return toRow(record.sequenceNumber(), record.valueKind(),
record.value());
+ }
+
+ public InternalRow toRow(long sequenceNumber, RowKind valueKind,
InternalRow value) {
Review Comment:
Suggest add a comment here.
record.key() is not write into row
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
