neuyilan commented on code in PR #4761:
URL: https://github.com/apache/paimon/pull/4761#discussion_r1896343987
##########
paimon-core/src/main/java/org/apache/paimon/io/DataFileMeta.java:
##########
@@ -135,7 +135,8 @@ public static DataFileMeta forAppend(
List<String> extraFiles,
Review Comment:
done
##########
paimon-core/src/main/java/org/apache/paimon/io/KeyValueFileWriterFactory.java:
##########
@@ -142,14 +142,15 @@ private KeyValueDataFileWriter createDataFileWriter(
fileIndexOptions);
}
- public void deleteFile(String filename, int level) {
-
fileIO.deleteQuietly(formatContext.pathFactory(level).toPath(filename));
+ public void deleteFile(DataFileMeta meta, int level) {
+ fileIO.deleteQuietly(formatContext.pathFactory(level).toPath(meta));
}
- public void copyFile(String sourceFileName, String targetFileName, int
level)
+ public void copyFile(
+ String sourceFileName, String targetFileName, int level, String
externalPath)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
