XiaoHongbo-Hope commented on code in PR #4863:
URL: https://github.com/apache/paimon/pull/4863#discussion_r1908760143
##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -272,10 +272,14 @@ public void dropTable(Identifier identifier, boolean
ignoreIfNotExists)
try {
getTable(identifier);
} catch (TableNotExistException e) {
+ if (!tableExistsInFileSystem(getTableLocation(identifier),
DEFAULT_MAIN_BRANCH)) {
+ dropTableImpl(identifier);
Review Comment:
> Maybe we can move dropTableImpl before getTable in AbstractCatalog? and
dropTableImpl in HiveCatalog do the change: 1. client.getTable 2. if 1 not
exception out then do client.dropTable.
xxxImpl method does the function itself maybe better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
