XiaoHongbo-Hope commented on code in PR #5200:
URL: https://github.com/apache/paimon/pull/5200#discussion_r1979003762
##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -240,8 +254,69 @@ public List<String> listTables(String databaseName) throws
DatabaseNotExistExcep
return
listTablesImpl(databaseName).stream().sorted().collect(Collectors.toList());
}
+ @Override
+ public PagedList<String> listTablesPaged(
+ String databaseName, Integer maxResults, String pageToken)
+ throws DatabaseNotExistException {
+ return new PagedList<>(listTables(databaseName), null);
+ }
+
+ @Override
+ public PagedList<Table> listTableDetailsPaged(
+ String databaseName, Integer maxResults, String pageToken)
+ throws DatabaseNotExistException {
+ if (isSystemDatabase(databaseName)) {
+ List<Table> systemTables =
+ SystemTableLoader.loadGlobalTableNames().stream()
+ .map(
+ tableName -> {
+ try {
+ return getTable(
+
Identifier.create(databaseName, tableName));
+ } catch (TableNotExistException
ignored) {
+ LOG.warn(
+ "system table {}.{} does
not exist",
+ databaseName,
+ tableName);
+ return null;
+ }
+ })
+ .filter(Objects::nonNull)
+ .collect(Collectors.toList());
+ return new PagedList<>(systemTables, null);
+ }
+
+ // check db exists
+ getDatabase(databaseName);
+
+ return listTableDetailsPagedImpl(databaseName, maxResults, pageToken);
+ }
+
protected abstract List<String> listTablesImpl(String databaseName);
+ protected PagedList<Table> listTableDetailsPagedImpl(
+ String databaseName, Integer maxResults, String pageToken)
+ throws DatabaseNotExistException {
+ PagedList<String> pagedTableNames = listTablesPaged(databaseName,
maxResults, pageToken);
Review Comment:
will get table details directly in RestCatalog, this is the default
implements for other catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
