leaves12138 commented on code in PR #5226:
URL: https://github.com/apache/paimon/pull/5226#discussion_r1986516360
##########
paimon-format/src/main/java/org/apache/paimon/format/parquet/newreader/VectorizedParquetRecordReader.java:
##########
@@ -258,36 +260,44 @@ private boolean containsPath(Type parquetType, String[]
path, int depth) {
}
public boolean nextBatch() throws IOException {
- // Primary key table will use the last record, so we can't reset first
- // TODO: remove usage of the last record by primary key table after
batch reset
- if (rowsReturned >= totalRowCount) {
- return false;
- }
- for (ParquetColumnVector vector : columnVectors) {
- vector.reset();
- }
- columnarBatch.setNumRows(0);
- checkEndOfRowGroup();
-
- int num = (int) Math.min(batchSize, totalCountLoadedSoFar -
rowsReturned);
- for (ParquetColumnVector cv : columnVectors) {
- for (ParquetColumnVector leafCv : cv.getLeaves()) {
- VectorizedColumnReader columnReader = leafCv.getColumnReader();
- if (columnReader != null) {
- columnReader.readBatch(
- num,
- leafCv.getColumn().getType(),
- leafCv.getValueVector(),
- leafCv.getRepetitionLevelVector(),
- leafCv.getDefinitionLevelVector());
+ try {
+ // Primary key table will use the last record, so we can't reset
first
+ // TODO: remove usage of the last record by primary key table
after batch reset
+ if (rowsReturned >= totalRowCount) {
+ return false;
+ }
+ for (ParquetColumnVector vector : columnVectors) {
+ vector.reset();
+ }
+ columnarBatch.setNumRows(0);
+ checkEndOfRowGroup();
Review Comment:
Added other kind exception acception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
