wwj6591812 commented on code in PR #5234:
URL: https://github.com/apache/paimon/pull/5234#discussion_r1986707692
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/MergeTreeCompactManager.java:
##########
@@ -178,6 +212,14 @@ public void triggerCompaction(boolean fullCompaction) {
});
}
+ @VisibleForTesting
+ protected void refreshL0Files() {
Review Comment:
protected？
##########
paimon-core/src/main/java/org/apache/paimon/operation/KeyValueFileStoreWrite.java:
##########
@@ -268,21 +271,55 @@ private CompactManager createCompactManager(
userDefinedSeqComparator,
levels,
dvMaintainer);
- return new MergeTreeCompactManager(
- compactExecutor,
- levels,
- compactStrategy,
- keyComparator,
- options.compactionFileSize(true),
- options.numSortedRunStopTrigger(),
- rewriter,
- compactionMetrics == null
- ? null
- : compactionMetrics.createReporter(partition,
bucket),
- dvMaintainer,
- options.prepareCommitWaitCompaction(),
- options.needLookup());
+ if (options.compactionForceRefreshFiles()) {
+ Supplier<List<DataFileMeta>> latestL0FilesSupplier =
+ () ->
scanL0FileMetas(snapshotManager.latestSnapshot(), partition, bucket);
+ return new MergeTreeCompactManager(
+ compactExecutor,
+ levels,
+ compactStrategy,
+ keyComparator,
+ options.compactionFileSize(true),
+ options.numSortedRunStopTrigger(),
+ rewriter,
+ compactionMetrics == null
+ ? null
+ : compactionMetrics.createReporter(partition,
bucket),
+ dvMaintainer,
+ options.prepareCommitWaitCompaction(),
+ options.needLookup(),
+ latestL0FilesSupplier);
+ } else {
+ return new MergeTreeCompactManager(
+ compactExecutor,
+ levels,
+ compactStrategy,
+ keyComparator,
+ options.compactionFileSize(true),
+ options.numSortedRunStopTrigger(),
+ rewriter,
+ compactionMetrics == null
+ ? null
+ : compactionMetrics.createReporter(partition,
bucket),
+ dvMaintainer,
+ options.prepareCommitWaitCompaction(),
+ options.needLookup());
+ }
+ }
+ }
+
+ private List<DataFileMeta> scanL0FileMetas(Snapshot snapshot, BinaryRow
partition, int bucket) {
+ List<DataFileMeta> l0FileMetas = new ArrayList<>();
+ List<ManifestEntry> files =
+ scan.withSnapshot(snapshot)
+ .withPartitionBucket(partition, bucket)
+ .withLevelFilter(level -> level == 0)
+ .plan()
+ .files();
Review Comment:
List<DataFileMeta> l0FileMetas = new ArrayList<>(files.size());
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/MergeTreeCompactManager.java:
##########
@@ -178,6 +212,14 @@ public void triggerCompaction(boolean fullCompaction) {
});
}
+ @VisibleForTesting
+ protected void refreshL0Files() {
+ List<DataFileMeta> latestL0Files = new
ArrayList<>(latestL0FilesSupplier.get());
Review Comment:
Add a log here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
