yuzelin commented on code in PR #5268:
URL: https://github.com/apache/paimon/pull/5268#discussion_r1991281649
##########
paimon-core/src/test/java/org/apache/paimon/utils/TagManagerTest.java:
##########
@@ -136,6 +138,66 @@ public void testCreateTagWithTimeRetained() throws
Exception {
assertThat(tags.get(0).getValue()).contains("tag");
}
+ @Test
+ public void testCreateTagWithMultiThreads() throws Exception {
Review Comment:
https://github.com/apache/paimon/blob/0bad12d4d04a6fb52bae2203964d7e70365a76fb/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java#L137
It used `overwriteFileUtf8` which will overwrite the tag file if some other
procedure is creating the tag. And it won't throw exceptions. I think it's not
safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
