yuzelin commented on code in PR #5703:
URL: https://github.com/apache/paimon/pull/5703#discussion_r2131646564


##########
paimon-api/src/main/java/org/apache/paimon/Snapshot.java:
##########
@@ -214,7 +222,8 @@ public Snapshot(
             @Nullable Long deltaRecordCount,
             @Nullable Long changelogRecordCount,
             @Nullable Long watermark,
-            @Nullable String statistics) {
+            @Nullable String statistics,
+            Map<String, String> properties) {

Review Comment:
   @Nullable



##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1175,7 +1199,8 @@ private ManifestCompactResult compactManifest(@Nullable 
ManifestCompactResult la
                         0L,
                         0L,
                         latestSnapshot.watermark(),
-                        latestSnapshot.statistics());
+                        latestSnapshot.statistics(),
+                        Collections.emptyMap());

Review Comment:
   Here should be latestSnapshot.properties()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to