neuyilan commented on code in PR #5674:
URL: https://github.com/apache/paimon/pull/5674#discussion_r2132001960


##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -356,6 +356,12 @@
             <td>Boolean</td>
             <td>Optional endInput check partition expire used in case of batch 
mode or bounded stream.</td>
         </tr>
+        <tr>
+            <td><h5>external.compact</h5></td>
+            <td style="word-wrap: break-word;">false</td>
+            <td>Boolean</td>
+            <td>Whether to execute full compaction to external paths.</td>

Review Comment:
   use `compaction.external `?
   As all the configurations related to 'compact' start with 'compaction.', it 
is best to maintain the same style as the previous configuration



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to