luoyuxia commented on code in PR #5703:
URL: https://github.com/apache/paimon/pull/5703#discussion_r2135741860
##########
paimon-core/src/test/java/org/apache/paimon/manifest/ManifestCommittableSerializerCompatibilityTest.java:
##########
@@ -463,7 +463,7 @@ public void testCompatibilityToV2CommitV2() throws
IOException {
ManifestCommittableSerializer serializer = new
ManifestCommittableSerializer();
byte[] bytes = serializer.serialize(manifestCommittable);
- ManifestCommittable deserialized = serializer.deserialize(3, bytes);
+ ManifestCommittable deserialized =
serializer.deserialize(serializer.getVersion(), bytes);
Review Comment:
After look in deep again, maybe we still need to change to use
`serializer.getVersion()` which is v4 to deserialize it.
The version is for in which the data was serialized in java doc, in here,
the data is serialized with v4.
And in v4, we will serialize `properties` into the bytes, it deserialize
with v3, it'll skip the `properties` bytes and try to deserialize it as
`commitMessages` and throw `BufferUnderflowException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
