XiaoHongbo-Hope commented on code in PR #5745:
URL: https://github.com/apache/paimon/pull/5745#discussion_r2149723903
##########
paimon-api/src/main/java/org/apache/paimon/rest/RESTUtil.java:
##########
@@ -34,6 +37,8 @@
/** Util for REST. */
public class RESTUtil {
+ private static final Logger LOG = LoggerFactory.getLogger(RESTUtil.class);
Review Comment:
> Not used?
fixed
##########
paimon-core/src/main/java/org/apache/paimon/partition/PartitionUtils.java:
##########
@@ -69,4 +73,15 @@ public static Pair<Pair<int[], RowType>, List<DataField>>
constructPartitionMapp
public static PartitionInfo create(@Nullable Pair<int[], RowType> pair,
BinaryRow binaryRow) {
return pair == null ? null : new PartitionInfo(pair.getLeft(),
pair.getRight(), binaryRow);
}
+
+ public static String buildPartitionName(Map<String, String> partitionSpec)
{
+ if (partitionSpec.isEmpty()) {
+ return EMPTY_PARTITION_NAME;
Review Comment:
> just use ""
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
