caozhen1937 commented on code in PR #5209:
URL: https://github.com/apache/paimon/pull/5209#discussion_r2189638826
##########
paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java:
##########
@@ -360,6 +360,8 @@ public TagDeletion newTagDeletion() {
public abstract Comparator<InternalRow> newKeyComparator();
+ protected abstract List<CommitCallback> createCommitCallbacks(String
commitUser);
Review Comment:
> Can you move `AbstractFileStoreTable.createCommitCallbacks` to here and
remove `newCommit(user, callbacks)` method?
Hi @JingsongLi , how to use if user use oneself callbacks (now newCommit
function can't transport callbacks)?
config by `commit.callbacks` and `commit.callback.#.param`?
And how to get some result by callbacks that transported by method param?
(e.g. I store some meta in Callback implement class)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
