JingsongLi commented on code in PR #6173: URL: https://github.com/apache/paimon/pull/6173#discussion_r2309563634
########## paimon-core/src/main/java/org/apache/paimon/utils/CompactedChangelogPathResolver.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.utils; + +import org.apache.paimon.fs.Path; + +/** + * Utility class for resolving compacted changelog file paths. + * + * <p>This class provides functionality to resolve fake compacted changelog file paths to their real + * file paths, following the same protocol as CompactedChangelogFormatReaderFactory. + */ +public class CompactedChangelogPathResolver { + + /** + * Resolves compacted changelog file path to its real file path. Handles both real and fake + * compacted changelog file names as described in CompactedChangelogFormatReaderFactory. + * + * @param path the file path to resolve + * @return the resolved real file path + */ + public static Path resolveCompactedChangelogPath(Path path) { + // Check if this is a compacted changelog file by its .cc- extension + String[] nameAndFormat = path.getName().split("\\."); Review Comment: Maybe just create a method `isCompactedChangelogPath`. And just check it is starting with `compacted-changelog-`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
