Tan-JiaLiang commented on code in PR #6178:
URL: https://github.com/apache/paimon/pull/6178#discussion_r2312974599
##########
paimon-common/src/main/java/org/apache/paimon/fileindex/rangebitmap/BitSliceIndexBitmap.java:
##########
@@ -178,24 +183,34 @@ public RoaringBitmap32 topK(int k, @Nullable
RoaringBitmap32 foundSet) {
e = RoaringBitmap32.andNot(e, getSlice(i));
} else {
e = RoaringBitmap32.and(e, getSlice(i));
- break;
+ if (!allowDuplicates) {
Review Comment:
Should we need it?
##########
paimon-common/src/main/java/org/apache/paimon/fileindex/rangebitmap/BitSliceIndexBitmap.java:
##########
@@ -222,18 +237,23 @@ public RoaringBitmap32 bottomK(int k, @Nullable
RoaringBitmap32 foundSet) {
e = RoaringBitmap32.and(e, getSlice(i));
} else {
e = RoaringBitmap32.andNot(e, getSlice(i));
- break;
+ if (!allowDuplicates) {
Review Comment:
Should we need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
