Zouxxyy commented on code in PR #6817:
URL: https://github.com/apache/paimon/pull/6817#discussion_r2619114842
##########
paimon-core/src/main/java/org/apache/paimon/partition/PartitionValuesTimeExpireStrategy.java:
##########
@@ -117,5 +118,20 @@ public boolean test(
InternalArray nullCounts) {
return true;
}
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
Because Spark relies on the equals method of `PaimonScan` to determine
whether it can be reused, all of its fields must properly implement equals. The
`Predicate` has already been implemented equals, and PartitionPredicate needs
to be handled as well.
```
case class PaimonScan(
table: InnerTable,
requiredSchema: StructType,
pushDownPartitionFilters: Seq[PartitionPredicate],
pushDownDataFilters: Seq[Predicate],
override val pushDownLimit: Option[Int],
override val pushDownTopN: Option[TopN],
bucketedScanDisabled: Boolean = false)
```
##########
paimon-core/src/main/java/org/apache/paimon/partition/PartitionValuesTimeExpireStrategy.java:
##########
@@ -117,5 +118,20 @@ public boolean test(
InternalArray nullCounts) {
return true;
}
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
Because Spark relies on the equals method of `PaimonScan` to determine
whether it can be reused, all of its fields must properly implement equals. The
`Predicate` has already been implemented equals, and PartitionPredicate needs
to be handled as well.
```scala
case class PaimonScan(
table: InnerTable,
requiredSchema: StructType,
pushDownPartitionFilters: Seq[PartitionPredicate],
pushDownDataFilters: Seq[Predicate],
override val pushDownLimit: Option[Int],
override val pushDownTopN: Option[TopN],
bucketedScanDisabled: Boolean = false)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
