YannByron commented on code in PR #7097:
URL: https://github.com/apache/paimon/pull/7097#discussion_r2739870380


##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/catalyst/analysis/RowLevelHelper.scala:
##########
@@ -95,4 +95,13 @@ trait RowLevelHelper extends SQLConfHelper {
       table.getTable.asInstanceOf[FileStoreTable],
       condition)
   }
+
+  /** Determines if DataSourceV2 update is not supported for the given table. 
*/
+  protected def shouldFallbackToV1Update(table: SparkTable, updateTable: 
UpdateTable): Boolean = {
+    shouldFallbackToV1(table) ||
+    !updateTable.rewritable ||

Review Comment:
   `updateTable.rewritable` should always be true here, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to