luoyuxia commented on code in PR #101:
URL: https://github.com/apache/paimon-rust/pull/101#discussion_r2872224031
##########
crates/paimon/src/io/file_io.rs:
##########
@@ -137,7 +138,7 @@ impl FileIO {
statuses.push(FileStatus {
size: meta.content_length(),
is_dir: meta.is_dir(),
- path: entry.path().to_string(),
+ path: format!("{base_path}{}", entry.path()),
Review Comment:
IIUC, `format!("{base_path}{}", entry.path())` just add leading `/` to
`entry.path()`?
Considering openal will always call `normalize_path` to remove leading `/`,
do we real need to add eading `/` to `entry.path()`? Could you just keep
`entry.path()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
