luoyuxia commented on code in PR #264:
URL: https://github.com/apache/paimon-rust/pull/264#discussion_r3137457313
##########
crates/paimon/src/table/snapshot_manager.rs:
##########
@@ -150,6 +151,28 @@ impl SnapshotManager {
self.find_by_list_files(i64::min).await
}
+ /// List all snapshot ids sorted ascending.
+ pub async fn list_all_ids(&self) -> crate::Result<Vec<i64>> {
+ let snapshot_dir = self.snapshot_dir();
+ let statuses = self.file_io.list_status(&snapshot_dir).await?;
Review Comment:
Seems it will return error when the snapshot dir doesn't exists. Is it
expected to return error instead of empty vec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
