JingsongLi commented on code in PR #8214:
URL: https://github.com/apache/paimon/pull/8214#discussion_r3457705161
##########
paimon-core/src/main/java/org/apache/paimon/operation/commit/ConflictDetection.java:
##########
@@ -643,30 +643,81 @@ Optional<RuntimeException> checkRowIdExistence(
.collect(Collectors.toList());
RowRangeIndex existingIndex = RowRangeIndex.create(existingRanges,
false);
+ // Row-id ranges removed by this same commit, keyed by partition and
bucket. A
+ // copy-on-write update on a data-evolution table deletes whole row-id
groups and re-adds
+ // rewritten rows with their original row ids. File rolling may make
an added file cover
+ // only a sub-range of a deleted group and not mirror an existing file
exactly; it is still
+ // consistent as long as its range is fully covered by ranges deleted
in this commit
+ // (concurrent rewrites of those files are caught by the regular
deleted-file conflict
+ // checks).
+ Map<Pair<BinaryRow, Integer>, List<Range>> deletedRanges = new
HashMap<>();
Review Comment:
Is this needed by UPDATE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
