JingsongLi commented on code in PR #8053: URL: https://github.com/apache/paimon/pull/8053#discussion_r3458755876
########## paimon-python/pyproject.toml: ########## @@ -0,0 +1,129 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +[build-system] +requires = [ + "setuptools>=61", + "wheel", +] +build-backend = "setuptools.build_meta" + +[project] +name = "pypaimon" +version = "1.5.dev" Review Comment: This drops the dynamic dev-version behavior from the old setup.py. Before this PR, `python setup.py sdist` registered an atexit hook that repacked `1.5.dev` into `1.5.devYYYYMMDD` based on the commit date. With the new static metadata I built the PR locally via `python -m build --sdist` and it only produced `pypaimon-1.5.dev0.tar.gz`. If snapshot/dev package publishing relies on monotonically increasing versions, repeated builds will all have the same normalized version and can no longer be uploaded or selected as newer builds. Could we port the dynamic version generation to the pyproject build path (for example via a build hook/setuptools-scm) or explicitly confirm that this behavior is no longer needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
