aisk commented on code in PR #8083: URL: https://github.com/apache/paimon/pull/8083#discussion_r3466953681
########## paimon-python/dev/requirements-dev.txt: ########## @@ -15,17 +15,22 @@ # See the License for the specific language governing permissions and # limitations under the License. ################################################################################ -# Core dependencies for pypaimon are in requirements.txt +# Core dependencies for pypaimon +-r requirements.txt # Test dependencies for pypaimon are as follows -duckdb==1.3.2 +duckdb==1.3.2; python_version >= "3.8" Review Comment: Sorry, I accidentally reverted the commit that fixed this earlier as well. I've re-committed it now, restoring the Python 3.8 fallback (`duckdb<1.3` for 3.8, `duckdb==1.3.2` for 3.9+). ########## paimon-python/dev/requirements-dev.txt: ########## @@ -15,17 +15,22 @@ # See the License for the specific language governing permissions and # limitations under the License. ################################################################################ -# Core dependencies for pypaimon are in requirements.txt +# Core dependencies for pypaimon +-r requirements.txt Review Comment: I've switched to the `pyroaring>=1.0.0` approach for all Python versions now, so 3.6/3.7 build it from source and keep `BitMap64` available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
