CrownChu commented on code in PR #8000:
URL: https://github.com/apache/paimon/pull/8000#discussion_r3527880128
##########
pom.xml:
##########
@@ -519,6 +519,19 @@ under the License.
</activation>
</profile>
+ <profile>
+ <!-- paimon-eslib depends on Java-11 eslib-api/eslib-core (Lucene
9.12), so it must be
+ built with JDK 11+. Activated only on JDK 11+ (like
paimon-iceberg) so the default
+ JDK-8 build skips it instead of failing the
RequireJavaVersion enforcer rule. -->
+ <id>paimon-eslib</id>
+ <modules>
+ <module>paimon-eslib</module>
+ </modules>
+ <activation>
+ <jdk>11</jdk>
Review Comment:
Thanks. <jdk>11</jdk> is a prefix match that only fires on JDK 11, so 17/21
builds silently skipped the module. Changed both the root paimon-eslib profile
and the paimon-spark-3.5 paimon-eslib profile to activate on
<jdk>[11,)</jdk> — the Spark-side one had no <activation> at all, so it now
auto-activates in sync with the root, and JDK 8 still skips both. Verified with
mvn help:active-profiles that paimon-eslib is now active on JDK 11 and 17.
Fixed in c2e1f85.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
