JingsongLi commented on PR #510:
URL: https://github.com/apache/paimon-rust/pull/510#issuecomment-4954599081

   There are multiple correctness issues:
   - When comparing the null Arrow value without checking its validity, 'NULL 
->0' will be judged as unchanged; The minimum regression I added actually 
returns' [] 'and expects' (1,0)'.
   - Diff only compares projection columns; When the value changes without 
projection, it will be missed, and if the projection does not include PK, it 
will directly report an error. The second minimum regression also returns an 
empty result.
   - Claiming to support types larger than the actual support range of 
comparator, runtime failures such as timestamp/time/financial; NaN will also be 
treated as equal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to