jianguotian commented on code in PR #10464:
URL: https://github.com/apache/paimon/pull/10464#discussion_r4237422970
##########
paimon-core/src/main/java/org/apache/paimon/catalog/Catalog.java:
##########
@@ -1158,6 +1158,17 @@ default void dropPartitions(Identifier identifier,
List<Map<String, String>> par
}
}
+ /**
+ * Remove the {@code .done} markers corresponding to the supplied data
partitions. Ignore
+ * missing markers and never delete table data. Catalogs which store these
markers must override
+ * this method.
+ *
+ * @param identifier path of the table
+ * @param partitions original data partition specs, without the marker
suffix
+ */
+ default void dropDonePartitions(Identifier identifier, List<Map<String,
String>> partitions)
Review Comment:
> I think you should ignore this P1 issue; adding a new interface for such a
simple matter really isn't worth it.
This DATE-related P1 occurs during partition expiration with HiveCatalog
when `metastore.partitioned-table=true` and the last partition column is DATE.
I'll keep this PR focused on DATE partition expiration, as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
