lucasfang commented on code in PR #425:
URL: https://github.com/apache/paimon-cpp/pull/425#discussion_r4244340756
##########
src/paimon/core/catalog/file_system_catalog_test.cpp:
##########
@@ -1255,6 +1256,41 @@ TEST(FileSystemCatalogTest, TestListSnapshots) {
ASSERT_LT(snapshots[0].snapshot_id, snapshots[1].snapshot_id);
}
+TEST(FileSystemCatalogTest, TestGetLatestSnapshot) {
Review Comment:
Test setup should stay consistent with the adjacent TestListSnapshots. The
new FS tests build the catalog directly on the read-only checked-in fixture
root (GetDataDir() / GetDataDir() + "/orc") via
std::make_shared<LocalFileSystem>(), whereas TestListSnapshots first copies the
fixture into a UniqueTestDirectory and builds the catalog through
CoreOptions::FromMap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
