lxy-9602 commented on code in PR #423:
URL: https://github.com/apache/paimon-cpp/pull/423#discussion_r4245762010
##########
src/paimon/core/operation/abstract_split_read.cpp:
##########
@@ -181,8 +183,13 @@ Result<std::unique_ptr<FileBatchReader>>
AbstractSplitRead::ApplyIndexAndDvReade
const std::shared_ptr<arrow::Schema>& read_schema, const
std::shared_ptr<Predicate>& predicate,
DeletionVector::Factory dv_factory, const
std::optional<std::vector<Range>>& row_ranges,
const std::shared_ptr<DataFilePathFactory>& data_file_path_factory) const {
+ std::shared_ptr<DeletionVector> deletion_vector;
+ if (dv_factory) {
+ PAIMON_ASSIGN_OR_RAISE(deletion_vector, dv_factory(file->file_name));
+ }
std::shared_ptr<FileIndexResult> file_index_result;
- if (options_.FileIndexReadEnabled()) {
+ if (options_.FileIndexReadEnabled() &&
+ dynamic_cast<Bitmap64DeletionVector*>(deletion_vector.get()) ==
nullptr) {
PAIMON_ASSIGN_OR_RAISE(
Review Comment:
// File index selections use 32-bit positions. Fall back when they cannot
safely represent
// the file or its deletion vector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
