lszskye commented on code in PR #427:
URL: https://github.com/apache/paimon-cpp/pull/427#discussion_r4246409314
##########
src/paimon/core/operation/read_context.cpp:
##########
@@ -18,21 +18,71 @@
#include "paimon/read_context.h"
+#include <map>
+#include <string>
#include <utility>
#include "arrow/c/abi.h"
#include "arrow/c/bridge.h"
#include "paimon/catalog/catalog.h"
+#include "paimon/catalog_options.h"
#include "paimon/common/utils/path_util.h"
+#include "paimon/common/utils/string_utils.h"
+#include "paimon/common/utils/url_utils.h"
#include "paimon/core/utils/branch_manager.h"
#include "paimon/executor.h"
#include "paimon/memory/memory_pool.h"
#include "paimon/status.h"
#include "paimon/table/format/format_table.h"
+#include "rapidjson/document.h"
+#include "rapidjson/stringbuffer.h"
+#include "rapidjson/writer.h"
namespace paimon {
class Predicate;
+namespace {
+
+/// The catalog option that carries the `X-Paimon-Read-Via` request header,
spelled with the prefix
+/// a REST catalog strips when it turns an option into a header. That prefix is
+/// `RestApi::kHeaderOptionPrefix`, not referenced here because its header
pulls in the http client;
+/// mirrors the Java `RESTApi.READ_VIA_OPTION`.
+constexpr char kReadViaOption[] = "header.X-Paimon-Read-Via";
Review Comment:
please move `kReadViaOption` in RESTApi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
