zjw1111 commented on code in PR #424:
URL: https://github.com/apache/paimon-cpp/pull/424#discussion_r4246765283
##########
src/paimon/global_index/full_text/full_text_global_index_test.cpp:
##########
@@ -395,6 +391,10 @@ TEST_F(FullTextGlobalIndexTest, TestWriteAndSearch) {
ASSERT_OK_AND_ASSIGN(auto result,
reader->VisitFullTextSearch(MakeSearch(MatchQuery("THE LAKE"))));
CheckRowIds(result, {0, 2});
+ ASSERT_OK_AND_ASSIGN(
+ result, reader->VisitFullTextSearch(
+ MakeSearch(R"({"multi_match":{"query":"paimon
lake","columns":["text"]}})")));
Review Comment:
Could you add UT coverage for these two cases?
- A `boolean` query containing another `boolean`, for both `full-text` and
`lucene-fts`, for example `A AND (B OR C)`, with assertions on the expected
matching row IDs. The current boolean cases only contain leaf queries.
- The `match.boost` parameter in the native `full-text` plugin. Compare the
same query with `boost: 1.0` and `boost: 2.0`, checking that the matching row
IDs stay the same and that the returned scores reflect the multiplier. The
current native plugin tests do not exercise this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
