JingsongLi commented on PR #1158: URL: https://github.com/apache/paimon-rust/pull/1158#issuecomment-6266687054
Thanks for the fix. The credential-precedence bug has real end-to-end impact, and this implementation passed local review: 19 S3 configuration/builder tests plus two additional public FileIO tests that perform actual HTTP S3 reads and inspect the signed requests. Both the canonical credential tuple and dotted-key fallback reach the request correctly. However, the earlier open PR #1156 already contains the same alias mapping, canonical token lookup, and equivalent regression coverage for #1154. The runtime difference here is only spelling the same token key as a string instead of a constant, so merging both provides no additional end-to-end behavior. Closing this duplicate and retaining #1156 as the single fix for #1154. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
