0dunay0 commented on code in PR #10601:
URL: https://github.com/apache/paimon/pull/10601#discussion_r4320974038


##########
paimon-format/src/main/java/org/apache/paimon/format/parquet/ParquetSchemaConverter.java:
##########
@@ -214,7 +240,11 @@ public static Type convertToParquetType(String name, 
DataType type, int fieldId,
             case TIMESTAMP_WITH_LOCAL_TIME_ZONE:
                 LocalZonedTimestampType localZonedTimestampType = 
(LocalZonedTimestampType) type;
                 return createTimestampWithLogicalType(
-                                name, localZonedTimestampType.getPrecision(), 
repetition, true)
+                                name,
+                                localZonedTimestampType.getPrecision(),
+                                repetition,
+                                true,
+                                localZonedTimestampMillisAsMicros)

Review Comment:
   - both column validation and literal conversion now follow the file's unit.
   - The rollout section is now in `docs/docs/iceberg/data-types.md` and the PR 
description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to