JingsongLi commented on code in PR #1042:
URL: https://github.com/apache/paimon-rust/pull/1042#discussion_r4345235098
##########
crates/paimon/src/table/table_read.rs:
##########
@@ -776,10 +776,21 @@ impl<'a> PaimonTableRead<'a> {
}
}
}
- // Delta / Changelog rows are read as-is from planned files (no
full-table
- // merge against historical base versions).
+ // Delta / Changelog rows are read as-is from planned files, without a
merge
+ // against historical base versions. Files are still decoded as an
ordinary
+ // read decodes them: primary-key BLOB descriptors resolve to
payloads, and
+ // data-evolution files in a split that hold column slices of the same
rows
+ // merge by row id.
let data_splits = self.matching_splits(&data_splits)?;
- self.new_data_file_reader()?.read(&data_splits)
+ let core_options = self.table.schema().core_options();
+ if !self.table.schema().primary_keys().is_empty() {
+ return self
+ .resolving_primary_key_blobs(&core_options, |read|
read.read_raw(&data_splits));
+ }
+ if core_options.data_evolution_enabled() {
+ return self.read_with_evolution(&data_splits, &core_options);
Review Comment:
[P2] Keep dedicated-only VECTOR updates readable incrementally
This unconditional DE routing regresses a valid existing
to_incremental_arrow call. With row tracking, data evolution and
vector.file.format=parquet enabled, the public data-evolution writer updating
only embedding intentionally commits a single *.vector.parquet file. Delta
(1,2] therefore contains only that streaming file. On this head the new
evolution-reader path errors with "Field merge split with .blob/.vector. files
requires at least one normal data file"; the identical public-API probe passes
on base 8d08e48a and returns the rewritten vectors with the unwritten id column
NULL. The ordinary evolution reader's pre-existing dedicated-only limitation
does not apply to the baseline raw incremental reader. Preserve dedicated-only
change-event decoding, or support its row-range anchor in the merge reader,
without borrowing historical files outside the requested range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
