JingsongLi commented on PR #10706: URL: https://github.com/apache/paimon/pull/10706#issuecomment-6334430015
Reviewed this as an independently shippable production change. The broader PIP-39 goal is useful, but this PR does not yet deliver an end-to-end lake-stream capability: `lakestream.store` has no runtime consumer, and the only consumer of `lakestream.enabled` is the rename/replace guard. No engine routes writes to a store or resolves the `$rt` read path. This is also explicitly acknowledged in the PR and issue #10692. As a result, enabling the advertised option currently adds catalog restrictions without providing the routing and freshness described in the generated configuration reference. Please include these options and identity guards with the first working engine/store integration, together with tests that write through the store and read the combined result. Closing this standalone foundation PR under the end-to-end review criterion; this does not reject the overall PIP-39 direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
