thswlsqls opened a new pull request, #10763:
URL: https://github.com/apache/paimon/pull/10763

   
   ### Purpose
   
   fix #10762
   
   - `CoreOptions#changelogRowDeduplicateIgnoreFields` split the value on `,` 
without trimming, so `'a, b'` produced `" b"` and `b` was not ignored.
   - With `changelog-producer.row-deduplicate = true`, an update that changes 
only `b` still emitted `-U`/`+U`, with no error or warning.
   - Trim each name, using the same form as `sequenceField()` after #6651.
   
   ### Tests
   
   - Added `CoreOptionsTest#testChangelogRowDeduplicateIgnoreFieldsTrim`, 
mirroring `testSequenceFieldTrim`.
   - Added 
`IncrementalDeltaStartingScannerTest#testRowDeduplicateIgnoreFieldsWithSpaces`: 
lookup changelog producer, `'a, b'`, update changing only `b`; the changelog is 
empty. Before the fix it fails with `Expecting empty but was: ["-U 1|10|100", 
"+U 1|10|500"]`.
   - `mvn -pl paimon-api,paimon-core test 
-Dtest=CoreOptionsTest,IncrementalDeltaStartingScannerTest`: BUILD SUCCESS, 0 
failures (22/22 and 5/5). `mvn spotless:check` passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to