Fokko commented on code in PR #1141:
URL: https://github.com/apache/parquet-mr/pull/1141#discussion_r1576417431
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/CodecFactory.java:
##########
@@ -48,7 +51,7 @@ public class CodecFactory implements CompressionCodecFactory {
private final Map<CompressionCodecName, BytesCompressor> compressors = new
HashMap<>();
private final Map<CompressionCodecName, BytesDecompressor> decompressors =
new HashMap<>();
- protected final Configuration configuration;
Review Comment:
For Iceberg this is not an issue, since we would remove this class with the
1.14 release (that contains https://github.com/apache/parquet-mr/pull/1134):
https://github.com/apache/iceberg/blob/866021d7d34f274349ce7de1f29d113395e7f28c/parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java#L28-L32
In Iceberg we shade Parquet, so this will not interfere with other libraries
that use a different version of Parquet. I'm curious what if we also have this
issue on the Spark side (cc @vinooganesh).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
