gszadovszky commented on code in PR #1369:
URL: https://github.com/apache/parquet-java/pull/1369#discussion_r1626350188
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -534,8 +534,9 @@ private void addRowGroup(
int columnOrdinal = -1;
ByteArrayOutputStream tempOutStream = null;
for (ColumnChunkMetaData columnMetaData : columns) {
- ColumnChunk columnChunk =
- new ColumnChunk(columnMetaData.getFirstDataPageOffset()); // verify
this is the right offset
+ // There is no ColumnMetaData written after the chunk data, so set the
ColumnChunk
+ // file_offset to 0
+ ColumnChunk columnChunk = new ColumnChunk(0);
Review Comment:
@wgtmac, I agree to write invalid value here (0 is as invalid as -1 because
of the magic bytes at the beginning of the file) and remove the field for v3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
