hellishfire commented on issue #3011:
URL: https://github.com/apache/parquet-java/issues/3011#issuecomment-2362692613

   On another note, in InternalParquetRecordWriter.java    
   ```
     public void write(T value) throws IOException, InterruptedException {
       try {
         writeSupport.write(value);
         ++recordCount;
         checkBlockSizeReached();
       } catch (Throwable t) {
         aborted = true;
         throw t;
       }
     }
   ```
   
   Should we narrow the try-catch scope to exclude exceptions thrown by 
writeSupport (i.e. illegal input values denied by writeSupport), which is 
irrelevant to actual file io operation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to