wgtmac commented on code in PR #466:
URL: https://github.com/apache/parquet-format/pull/466#discussion_r1839196589
##########
LogicalTypes.md:
##########
@@ -648,49 +650,105 @@ optional group my_list (LIST) {
}
```
-Some existing data does not include the inner element layer. For
-backward-compatibility, the type of elements in `LIST`-annotated structures
-should always be determined by the following rules:
+##### 2-level structure
+
+Some existing data does not include the inner element layer, meaning that
`LIST`
+annotates a 2-level structure. In contrast to 3-level structure, the repetition
+of 2-level structure can be `optional`, `required`, or `repeated`.
Review Comment:
I just happen to see that this section is all about 2-level list so I have
added a title to make it explicit.
> The problem is when we need to decide whether a structure is a 2-level or
3-level.
The change aims to exhaust all possible forms of list structures and we can
just apply these rules in order to deduce a list type:
- regular 3-level list
- 3-level list (w/ different names)
- 2-level list
- 1-level list (w/o list annotation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
