emkornfield commented on code in PR #474:
URL: https://github.com/apache/parquet-format/pull/474#discussion_r1879063140
##########
src/main/thrift/parquet.thrift:
##########
@@ -384,6 +384,11 @@ struct BsonType {
* Embedded Variant logical type annotation
*/
struct VariantType {
+ // If the Variant is shredded the version of the shredding specification
used.
+ // Required, if the the column is shredded.
+ //
+ // See VariantShredding.md for differences between versions.
+ 1: optional i8 shredding_version
Review Comment:
encoding version is already embedded in metadata, so I thought wouldn't be
needed here. Shredding version is only encoded implicitly based on the spec
without this.
I think shredding should probably evolve differently from encoding
(hopefully we won't need to evolve any for some time). But shredding seems
like we need at least some more experimentation to determine if there are other
forms that might be better.
I might not be fully understanding the question here though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
