raulcd commented on code in PR #3101: URL: https://github.com/apache/parquet-java/pull/3101#discussion_r1882419390
########## dev/README.md: ########## @@ -91,3 +91,61 @@ Merge hash: 485658a5 Would you like to pick 485658a5 into another branch? (y/n): ``` For now just say n as we have 1 branch + +# Release Verification Review Comment: > I'm not sure why we need to check for the license headers separately in the tarball. It is already in the build process so we shall not have license header issues in the repo. I see, we can probably remove explicitly checking license headers. This is something that in general I've seen all projects do as part of their release verification process and something that I would say falls under the "verify that they meet all requirements of ASF policy on releases as described below" point on the [ASF release guide](https://www.apache.org/legal/release-policy.html#release-approval). But it is true that as soon as there hasn't been any change as those are already done feels unnecessary. How do you perform the comparison between the content of the tarball with a freshly cloned repo set to the release RC tag? Do we want to add that as a step? I will move the PR to the parquet-site one, I might take a couple of days as I am slightly busy at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
