redblackcoder commented on code in PR #240:
URL: https://github.com/apache/parquet-format/pull/240#discussion_r1911596567


##########
src/main/thrift/parquet.thrift:
##########
@@ -386,6 +417,64 @@ struct BsonType {
 struct VariantType {
 }
 
+/** Coordinate reference system (CRS) encoding for Geometry and Geography 
logical types */
+enum CRSEncoding {
+  SRID = 0;
+  PROJJSON = 1;
+}
+
+/** Edge interpolation algorithm for Geography logical type */
+enum EdgeInterpolationAlgorithm {
+  SPHERICAL = 0;
+  VINCENTY = 1;
+  THOMAS = 2;
+  ANDOYER = 3;
+  KARNEY = 4;
+}
+
+/**
+ * Embedded Geometry logical type annotation
+ *
+ * Geometry features in the Well-Known Binary (WKB) format with linear/planar
+ * edges interpolation.
+ *
+ * A custom CRS can be set to the crs field. If unset, the CRS defaults to
+ * "OGC:CRS84", which means that the geometries must be stored in longitude,
+ * latitude based on the WGS84 datum.
+ *
+ * crs_encoding is an auxillary field to help decode the crs text. If unset, 
the
+ * crs field can be arbitrary text.
+ *
+ * Allowed for physical type: BYTE_ARRAY.
+ */
+struct GeometryType {
+  1: optional string crs;
+  2: optional CRSEncoding crs_encoding;
+}
+
+/**
+ * Embedded Geography logical type annotation
+ *
+ * Geometry features in the WKB format with non-linear/non-planar edges

Review Comment:
   typo
   ```suggestion
    * Geography features in the WKB format with non-linear/non-planar edges
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to