wgtmac commented on code in PR #3148:
URL: https://github.com/apache/parquet-java/pull/3148#discussion_r1945984749
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -2123,6 +2123,9 @@ private PageHeader newDataPageV2Header(
int dlByteLength) {
DataPageHeaderV2 dataPageHeaderV2 = new DataPageHeaderV2(
valueCount, nullCount, rowCount, getEncoding(dataEncoding),
dlByteLength, rlByteLength);
+ if (compressedSize == 0) {
+ dataPageHeaderV2.setIs_compressed(false);
Review Comment:
BTW, I think the description in the spec needs to be improved since it does
not consider the case when `comressed_page_size` is 0:
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L665-L668
> Which means the section of the page between definition_levels_byte_length
+ repetition_levels_byte_length + 1 and compressed_page_size (included) is
compressed with the compression_codec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
