ggershinsky commented on code in PR #3148:
URL: https://github.com/apache/parquet-java/pull/3148#discussion_r1948994957
##########
parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCtrDecryptor.java:
##########
@@ -55,7 +55,11 @@ public byte[] decrypt(byte[] lengthAndCiphertext, byte[]
AAD) {
public byte[] decrypt(byte[] ciphertext, int cipherTextOffset, int
cipherTextLength, byte[] AAD) {
int plainTextLength = cipherTextLength - NONCE_LENGTH;
- if (plainTextLength < 1) {
+ if (plainTextLength == 0) {
Review Comment:
yep, technically this should work ok - unlike GCM, the CTR mode doesn't
guarantee/check the integrity, so we don't need to protect against page
replacement attacks (we can't anyway).
In terms of implementation, it might be a bit cleaner if we use cipher
decryption of zero-sized arrays; fewer lines of code. But I'll verify first if
this is supported in CTR, will get back on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
