ArnavBalyan commented on PR #3283: URL: https://github.com/apache/parquet-java/pull/3283#issuecomment-3232401753
> This is a great improvement. Thanks a lot for working on it! > > I have two ideas to improve it: > > * What do you think about adding the conf support centrally for every commands by setting it in [Main](https://github.com/apache/parquet-java/blob/4aa2ea91863274aebb1eded243ce275912c16010/parquet-cli/src/main/java/org/apache/parquet/cli/Main.java#L167-L167)? > * Maybe adding an additional option that supports reading a config file (and the config pairs at command line can override these values)? Thanks for the review and great suggestions! I'll address them shortly. Supporting it centrally for every command is a great point, let me check how we can wire it for all commands. Will add support for the config file also thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
